Remove spring slueth link to fix link check#8448
Merged
Merged
Conversation
Possibly as part of sleuth archival and its logic moving to micrometer, the automation requests for URL have started to return 404. This is short term fix, with long term as doc updates at docs/sdk-configuration-design.md to remove/replace sleuth references.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8448 +/- ##
============================================
+ Coverage 90.16% 91.02% +0.85%
- Complexity 7475 7817 +342
============================================
Files 836 893 +57
Lines 22551 23719 +1168
Branches 2224 2364 +140
============================================
+ Hits 20333 21590 +1257
+ Misses 1515 1408 -107
- Partials 703 721 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@ps-mir I was thinking about this just yesterday. Can we just remove the slueth link? The doc which contains it is maintained for historical purposes and not current or user facing. |
Contributor
Author
|
@jack-berg I thought about replacing Sleuth references with micrometer, wherever possible. But just removing the link will also be fine as an immediate fix. I'll make the change |
zeitlinger
approved these changes
Jun 4, 2026
jack-berg
approved these changes
Jun 4, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short-term fix for Build (daily) issue #8447 as per comment