Skip to content

Remove spring slueth link to fix link check#8448

Merged
jack-berg merged 2 commits into
open-telemetry:mainfrom
ps-mir:lychee_exclude_sleuth
Jun 4, 2026
Merged

Remove spring slueth link to fix link check#8448
jack-berg merged 2 commits into
open-telemetry:mainfrom
ps-mir:lychee_exclude_sleuth

Conversation

@ps-mir
Copy link
Copy Markdown
Contributor

@ps-mir ps-mir commented Jun 3, 2026

Short-term fix for Build (daily) issue #8447 as per comment

Possibly as part of sleuth archival and its logic moving to micrometer,
the automation requests for URL have started to return 404.

This is short term fix, with long term as doc updates at
docs/sdk-configuration-design.md to remove/replace sleuth references.
@ps-mir ps-mir requested a review from a team as a code owner June 3, 2026 08:13
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.02%. Comparing base (aa2ca12) to head (074542a).
⚠️ Report is 311 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8448      +/-   ##
============================================
+ Coverage     90.16%   91.02%   +0.85%     
- Complexity     7475     7817     +342     
============================================
  Files           836      893      +57     
  Lines         22551    23719    +1168     
  Branches       2224     2364     +140     
============================================
+ Hits          20333    21590    +1257     
+ Misses         1515     1408     -107     
- Partials        703      721      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jack-berg
Copy link
Copy Markdown
Member

@ps-mir I was thinking about this just yesterday. Can we just remove the slueth link? The doc which contains it is maintained for historical purposes and not current or user facing.

@ps-mir
Copy link
Copy Markdown
Contributor Author

ps-mir commented Jun 3, 2026

@jack-berg I thought about replacing Sleuth references with micrometer, wherever possible. But just removing the link will also be fine as an immediate fix. I'll make the change

@jack-berg jack-berg changed the title Exclude sleuth from lychee check Remove spring slueth link to fix link check Jun 4, 2026
Copy link
Copy Markdown
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ps-mir!

@jack-berg jack-berg merged commit 28f91ed into open-telemetry:main Jun 4, 2026
28 checks passed
@otelbot
Copy link
Copy Markdown
Contributor

otelbot Bot commented Jun 4, 2026

Thank you for your contribution @ps-mir! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants